Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flask): use rustup snap #1744

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix(flask): use rustup snap #1744

merged 3 commits into from
Jul 22, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jul 19, 2024

A new update to a flask dependency requires a more recent version of rustc than is available in the jammy repos.
This works around that by using the same rustup snap as the craft-parts rust plugin

Fixes #1743

Spread test failure is fixed in #1749

@lengau lengau force-pushed the work/flask-ext-fix branch 2 times, most recently from c84f7fe to a8cc2e3 Compare July 19, 2024 21:38
@lengau lengau marked this pull request as ready for review July 22, 2024 20:00
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

lengau added a commit that referenced this pull request Jul 22, 2024
Ubuntu Mantic is now EOL, causing launches to fail. Unfortunately, we
cannot replace this with oracular due to
canonical/craft-providers#598

Fix for Oracular is scheduled in
#1748

Spread test failure is fixed in #1744
@lengau lengau merged commit 3b05ba5 into main Jul 22, 2024
15 of 17 checks passed
@lengau lengau deleted the work/flask-ext-fix branch July 22, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flask-framework charm builds failing due to dependency
3 participants